Use oasis3-mct master branch in ACCESS-ESM1.6#311
Merged
dougiesquire merged 2 commits intomainfrom Sep 2, 2025
Merged
Conversation
dougiesquire
commented
Aug 27, 2025
dougiesquire
force-pushed
the
esm1.6-oasis3-mct-master
branch
from
55e86d9 to
0a82a48
Compare
harshula
reviewed
Aug 27, 2025
dougiesquire
force-pushed
the
esm1.6-oasis3-mct-master
branch
2 times, most recently
from
cce9240 to
0ca3c0d
Compare
penguian
reviewed
Sep 1, 2025
Collaborator
penguian
left a comment
penguian
left a comment
There was a problem hiding this comment.
What testing has been done so far?
dougiesquire
force-pushed
the
esm1.6-oasis3-mct-master
branch
from
0ca3c0d to
50861eb
Compare
Collaborator
|
Hi @dougiesquire , If you haven't already, please rebase your branch on to the latest |
Contributor
Author
|
Done |
Contributor
Author
|
@penguian, are you satisfied with my responses above? If so, could you please approve the PR? |
Collaborator
|
While I can approve, my knowledge of the ACCESS-NRI versioning scheme isn't sufficiently high to be confident. FWIW, the change seems to work fine with my local spack ESM1.6 builds for both regular oasis3-mct (which picks up access-om2) and upstream. |
Collaborator
|
Hi @dougiesquire , Please use squash-merge or commit-merge, whichever you think is more appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes changes to allow us to switch to using
oasis3-mctbuilt from themasterbranch, rather thanaccess-esm1.5branch, in ACCESS-ESM1.6.A
version("stable", branch="master", preferred=True)is introduced into theoasis3-mctSPR. Using this version in ACCESS-ESM1.6 does not change answers or performance (despite the associated change from-xCORE-AVX512to-axCORE-AVX2) - see here and here.